Re: [PATCH] gnu: Add quvi.

[Mark H Weaver]

Andreas Enge <address@hidden> writes:

> On Fri, Mar 06, 2015 at 05:47:26PM -0500, Mark H Weaver wrote:
>> I'm familiar with these packages, and I tend to agree that they are so
>> closely tied that it's reasonable to commit them together.
>
> That is not common practice so far, no? I do not see what would be
> the problem when committing them separately.

I don't feel strongly either way.

>> > Your indentation (here and further down) is not quite consistens, sometimes
>> > it it one, sometimes two spaces.
>> He's using the auto-indenter of Emacs Scheme Mode, which faithfully
>> follows the rules in our .dir-locals.el file.
>
> Curious. Why does it use sometimes one, sometimes two spaces? Can this be
> explained so that non-emacs users follow the same style?

I think we're trying to be tolerant of some inconsistency in
indentation, but the usual rule is that continuation lines within a
parenthesized list are lined up with the first argument (second list
item) on the first line, or if the first line only contains one list
item, then they are all lined up.  However, if there's an entry in
.dir-locals.el, then it is considered a special form and is indented two
spaces.

>> >> +          (string-append "liblua_LIBS=-L" lua "/libs -llua")))))
>> > These are two flags and should be two entries in the list.
>> What Taylan wrote above looks right to me.  The -L[...] and -llua are
>> two flags, but the variable setting "liblua_LIBS=-L[...]/libs -llua"
>> needs to be one argument to configure.
>
> I do not get this. Why should two flags be one argument? Do you mean that
> on the command line, one would write:
>   ./configure "liblua_LIBS=-L/gnu/store/.../libs -llua"

Yes.

> and that the call of system* adds these quotation marks implicitly?

It doesn't add quotation marks implicitly, but it does the same thing
that the shell would do if quotation marks were added, namely that the
entire quoted item is passed as a single argument to ./configure.

If they were instead passed as two arguments, as would be done with the
command

  ./configure liblua_LIBS=-L/gnu/store/.../libs -llua

Then the 'liblua_LIBS' variable would be "-L/gnu/store/.../libs" and
"-llua" would be passed as a separate argument to configure, which
certainly wouldn't do what we want and might raise an error.

      Mark