guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add Julia.


From: Ludovic Courtès
Subject: Re: [PATCH] Add Julia.
Date: Mon, 23 Mar 2015 10:29:11 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux)

Ricardo Wurmus <address@hidden> skribis:

> The release tarball comes with all dependencies bundled, but I tried
> hard to make it build against system libraries.  This didn't always
> work, unfortunately.
>
> libuv : Julia comes with a modified version of libuv and it won't build
>         with our libuv package at this point.  This has been confirmed
>         upstream[1].
>
> dSMFT : Upstream's Makefile does not have targets to build dSMFT as a
>         library.  The Makefile is only used to build test programmes.  I
>         have a rudimentary package for dSMFT ready, but it would have to
>         include a patch to the Makefile to actually build libraries.
>
> rmath : Julia uses a version of rmath that is patched to use the dSMFT
>         random number generator.  Upstream highly recommends using the
>         patched library.

OK.  It’s reasonable to leave them as is, perhaps with a link to your
message in a comment.

> suitesparse : Unfortunately, suitesparse only builds static libraries,
>         not shared ones, while Julia expects to find shared libraries.
>         I'm not sure what to patch here: Julia's build system so that it
>         builds shared libs from the suitesparse package output (rather
>         than the bundled tarball) or suitesparse such that it also
>         provides shared libs.

I would patch suitesparse to produce shared libs, but if it’s a
“hand-made” build system, it’ll probably have to produce either shared
libs or static libs, but not both (which would require building both PIC
and non-PIC objects, etc.)  Having it build shared libs only is probably
OK.

Regardless, it’s OK to push Julia as is for now, and adjust suitesparse
and Julia in eventual commits.

> This package depends on a couple of other packages that are still
> awaiting review:
>
> - double-conversion (patch attached below)
> - openblas[2] (needed because Julia doesn't build against Atlas)
> - utf8proc[3]

I think these two are done now, no?

> From dfe39329d60b38b684141cc0ce1d2bccd7ab637e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 20 Mar 2015 12:11:35 +0100
> Subject: [PATCH 1/2] gnu: Add double-conversion.
>
> * gnu/packages/maths.scm (double-conversion): New variable.

LGTM.

> From 41550ffafa8da05b2cf8dfad66d44e6f43c9042c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 20 Mar 2015 11:26:23 +0100
> Subject: [PATCH 2/2] gnu: Add Julia.
>
> * gnu/packages/julia.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

LGTM.

Thank you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]