Re: [PATCH] Add Csound and Solfege.

[Ricardo Wurmus]

Ludovic Courtès writes:

> Ricardo Wurmus <address@hidden> skribis:
>
>> patch-python-shebangs
>> :  Self-explanatory.  As at least one file is in ISO-8859 encoding this
>>    whole thing is wrapped in (with-fluids ((%default-port-encoding #f))
>>    ...)
>
> Why doesn’t the ‘patch-shebangs’ phase do its job?  Could
> ‘patch-shebang’ be used instead of ‘substitute*’?

The two affected files start with a Unicode BOM.  I simplified the phase
a little more, because it's really only two files that need this special
treatment, not all Python scripts.

>> adjust-config-file-prefix
>> :  Config files are usually loaded from /etc or /usr/share.  This
>>    phase sets the prefix to the package output directory.
>
> OK.  I suppose Solfege also supports reading per-user config files from
> ~/.config or similar?

It also reads ~/.solfegerc, but the default config file is used to
initialise the user config if it doesn't exist.

>> fix-gettext
>> :  I have no idea what's wrong with the i18n of Solfege.  Upon
>>    application start I'm greeted with locale errors and this particular
>>    line looks like just wrong.  "i18n" is None at this point and the
>>    application just crashes unless I comment the line.  I feel least
>>    comfortable with this hack and I'd be glad if someone could find a
>>    fix that makes this phase obsolete.
>
> I don’t know what the Python API looks like.  The gettext manual
> mentions an API with the ‘gettext.’ prefix, dunno if that’s a different
> thing.

I was wrong.  Not i18n is None, but i18n.translation is.  Dependent on
locale environment variables it will be set to hold the appropriate
translations.  In my case this didn't work for the following reasons:

* glibc-locales was not installed to my profile
* LOCPATH was not set to $out:/lib/locales of glibc-locales
* LC_ALL was not set; when I set it to en_GB it works fine

Since it works in a correctly configured environment I removed the
phase.

> OK to push with these changes!

Thanks for the review!  Pushed.

~~ Ricardo