Re: [PATCH 4/9] gnu: Add geoclue service.

[Ludovic Courtès]

Andy Wingo <address@hidden> skribis:

> * gnu/services/geoclue.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add geoclue service.

LGTM, but...

> +(define* (geoclue-service #:key (geoclue geoclue)
> +                          (whitelist '())
> +                          (wifi-geolocation-url
> +                           ;; Mozilla geolocation service:
> +                           
> "https://location.services.mozilla.com/v1/geolocate?key=geoclue";)
> +                          (submit-data? #f)
> +                          (wifi-submission-url
> +                           
> "https://location.services.mozilla.com/v1/submit?key=geoclue";)
> +                          (submission-nick "geoclue")
> +                          (applications %standard-geoclue-applications))
> +  "Return a service that runs the @command{geoclue}, location service."

... could you expound on the docstring, and then add it to guix.texi
like I did for colord?  Specifically, the docstring should mention all
the parameters and their meaning, possibly pointing to the upstream doc
for more details.

(I would do that, but since I’m geoclue-less [haha!] I’d rather let you
handle it.)

Thanks!

Ludo’.