[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] gnu: Add MariaDB.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 3/3] gnu: Add MariaDB. |
Date: |
Fri, 17 Apr 2015 14:07:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
宋文武 <address@hidden> skribis:
> * gnu/packages/database.scm (mariadb): New variable.
+s: “databases.scm”
> + 'configure 'pre-configure
> + (lambda _
> + (setenv "CONFIG_SHELL" (which "sh"))
> + ;; XXX: libstdc++.so lacks RUNPATH for libgcc_s.so.
> + (setenv "LDFLAGS" "-lgcc_s")
Indeed, but this is normally compensated by the fact that our GCC
automatically passed -Wl,-rpath=$gcclibdir, no? What error where you
getting without it?
> + ;; Install testing data to the 'test' output.
> + (mkdir-p test)
> + (system* "mv" (string-append out "/data") test)
> + (system* "mv" (string-append out "/mysql-test") test)
> + (system* "mv" (string-append out "/sql-bench") test)))
Could you use ‘rename-file’?
Otherwise LGTM.
Thanks,
Ludo’.