guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add IR.


From: Andreas Enge
Subject: Re: [PATCH] gnu: Add IR.
Date: Sun, 26 Apr 2015 14:09:59 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Sat, Apr 25, 2015 at 08:49:43PM +0200, Ricardo Wurmus wrote:
> +          (chdir "libs") #t)

I would put "#t" onto a new line as it is a separate "command".

+            (("^LIBDIR =.*") "LIBDIR = lib\n"))

I think this adds a line break, which is not a problem.

> +     "Zita convolver is a C++ library implementing a real-time convolution
> +matrix.")

This I find difficult to understand. How can you implement a matrix?  What is
a real time matrix?  Maybe "for computing convolution matrices in real time"?
Or also add "double precision" (or whatever is correct) in front of
"convolution matrices".

Otherwise looks good.

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]