guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] services: Add console-keymap service.


From: Ludovic Courtès
Subject: Re: [PATCH] services: Add console-keymap service.
Date: Wed, 29 Apr 2015 22:23:06 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Alex Kost <address@hidden> skribis:

> From f879481f96386617d070b146aa2c3d1988deff40 Mon Sep 17 00:00:00 2001
> From: Alex Kost <address@hidden>
> Date: Sat, 25 Apr 2015 22:52:29 +0300
> Subject: [PATCH] services: Add console-keymap service.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/services/base.scm (console-keymap-service): New procedure.
> * doc/guix.texi (Base Services): Document it.
>
> Co-authored-by: 宋文武 <address@hidden>

[...]

> +      (documentation
> +       (string-append "Load '" file "' console keymap (loadkeys)."))

Please make it a literal string, thus omitting FILE entirely.

Otherwise LGTM, please push.

Eventually, this should probably be promoted as a field in
‘operating-system’, with the service automatically added as part of
‘essential-services’.  WDYT?

Thanks to both of you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]