guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: base: Add glibc-hurd and hurd-minimal.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: base: Add glibc-hurd and hurd-minimal.
Date: Mon, 04 May 2015 17:11:16 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Manolis Ragkousis <address@hidden> skribis:

> From c64bb1c8c91b8f50d2955f5ae3bd1c8735ff40d9 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Sat, 27 Sep 2014 20:07:19 +0300
> Subject: [PATCH] gnu: base: Add glibc-hurd and hurd-minimal.
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> * gnu/packages/base.scm (glibc/hurd, glibc/hurd-headers): New variables.
> * gnu/packages/hurd.scm (hurd-minimal): New variable.
> * gnu/packages/patches/glibc-hurd-extern-inline.patch: New file.
> * gnu/packages/patches/libpthread-glibc-preparation.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add them.
>
> Co-authored-by: Ludovic Courtès <address@hidden>
> Co-authored-by: Mark H Weaver <address@hidden>

[...]

> +                           "ac_cv_search_clnt_create=no")

Could you add the rationale as a comment just above (“Skip the
clnt_create check because ...”)?

> +     "This package provides libihash, needed to build the GNU C 
> +Library for GNU/Hurd")

Missing period.

OK to commit to wip-hurd with these changes, thank you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]