Re: 01/03: gnu: mozjs: Mark as unsupported on mips64el-linux.

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> Ludovic Courtès <address@hidden> writes:
>
>> civodul pushed a commit to branch master
>> in repository guix.
>>
>> commit 4bfeb0ca74fca75febe62b8e059b0c5a6ddd622f
>> Author: Ludovic Courtès <address@hidden>
>> Date:   Tue May 5 21:39:18 2015 +0200
>>
>>     gnu: mozjs: Mark as unsupported on mips64el-linux.
>
> [...]
>
>> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
>> index 522404f..8031a6c 100644
>> --- a/gnu/packages/gnuzilla.scm
>> +++ b/gnu/packages/gnuzilla.scm
>> @@ -85,7 +85,12 @@
>>      (synopsis "Mozilla javascript engine")
>>      (description "SpiderMonkey is Mozilla's JavaScript engine written
>>  in C/C++.")
>> -    (license license:mpl2.0))) ; and others for some files
>> +    (license license:mpl2.0)                      ;and others for some files
>> +
>> +    ;; On mips64el, this fails to build with several "control reaches end of
>> +    ;; non-void function" errors (see
>> +    ;; <http://hydra.gnu.org/build/407741/nixlog/3/raw>.)
>> +    (supported-systems (delete "mips64el-linux" %supported-systems))))
>
> In general, I would prefer not to mark packages as unsupported on a
> platform unless there is good reason to believe that the problems would
> be very difficult to resolve.

For me the reasoning was that if it doesn’t even build, then it’s
effectively unsupported upstream, but...

> In this case, Debian contains builds of mozjs for MIPS, and MIPS is
> supported by the Mozilla project.  For example, see:
>
>   https://bugzilla.mozilla.org/show_bug.cgi?id=902818
>
> where a mozjs bug is reported on MIPS (N32 ABI) and later fixed by
> upstream.

... I admit I had not done this research, and this is indeed
encouraging.

> Furthermore, mozjs is an important package.  polkit depends on mozjs,
> and several important GNOME components depend on polkit, so without
> mozjs we cannot have GNOME on MIPS.
>
> So, I would prefer to revert this commit.  What do you think?

OK, fine with me.  Now to find the upstream patch that fixes the issue...

Sorry for the inconvenience!

Ludo’.