Re: [PATCH] website : ...

[Ludovic Courtès]

Could you create yourself an account on Savannah so I can add you to the
project?  That will make it easier to work on these changes.

Mathieu Lirzin <address@hidden> skribis:

> From 8d61be9cdd787265b7bb7e1232546f5e7f3997e3 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <address@hidden>
> Date: Thu, 7 May 2015 21:21:02 +0200
> Subject: [PATCH 1/3] website: Enable directory choice in export procedure.

OK.

> From 4763ec6706b9f5088b00f3b99f4e3eca57b05d8a Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <address@hidden>
> Date: Fri, 8 May 2015 00:06:03 +0200
> Subject: [PATCH 2/3] website: Factorize shared blocks.

OK.

> From c36af581753b015f31a562d2fe8992465d15f36e Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <address@hidden>
> Date: Fri, 8 May 2015 04:56:17 +0200
> Subject: [PATCH 3/3] website: Fix URLs.

[...]

> -                              (a (@ (href 
> "http://www.gnu.org/philosophy/free-sw.html";)
> +                              (a (@ (href 
> "https://www.gnu.org/philosophy/free-sw.html";)

I think this should be (gnu-url "philosophy/free-sw.html"), which would
return “/philosophy/free-sw.html” by default (with a ‘gnu.org-root’
parameter object.)

> -                           (a (@ (href "/software/guix/download/")
> +                           (a (@ (href ,(url-base "/download"))

Maybe (base-url "download") would be clearer.

> +                 (img (@ (src ,(img-url "h-separator-darker.png"))

s/img-url/image-url/

> +(define current-url-root
> +  (make-parameter "/home/mthl/src/gnu/guix-artwork/website/build"))

Rather default to “/software/guix”.

> +(define resources-url-root
> +  (make-parameter "https://www.gnu.org/s/guix";))

Default to (current-url-root).

OK for me with these changes.

Thank you!

Ludo’.