guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] website : ...


From: Ludovic Courtès
Subject: Re: [PATCH] website : ...
Date: Sat, 09 May 2015 16:22:41 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Mathieu Lirzin <address@hidden> skribis:

> From f6b50dfccae0d493705c600587324153c96a90d0 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <address@hidden>
> Date: Fri, 8 May 2015 04:56:17 +0200
> Subject: [PATCH] website: Fix URLs.
>
> Enable local export to link URLs correctly.
>
> * website/www/utils.scm: New file.

I think it’s a good idea to use GNU ChangeLog-style logs, but I won’t
require it for the web site.  If you want to do that, remember to
mention all the files and procedures/variables that are
added/removed/modified.  (See the GNU Coding Standards for details on
ChangeLogs.)

[...]

> +(define (guix-url location)
> +  (string-append (gnu-url "s/guix/") location))

“software/guix” rather than “s/guix”.

OK to push with this change (with or without ChangeLog-style commit
log), and with the two previous patches.

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]