[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add guile-emacs!
From: |
Taylan Ulrich Kammer |
Subject: |
Re: [PATCH] Add guile-emacs! |
Date: |
Thu, 14 May 2015 10:56:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Christopher Allan Webber <address@hidden> writes:
> Okay, how about a version of guile-emacs that works and incorporates
> feedback from this thread? Yeah? Anyone?
>
> Whoooooooooo guile-emacs! :)
Yay! :-)
I would have thought these would go to guile.scm and emacs.scm. What do
others think?
> +(define-public guile-for-guile-emacs
> [...]
> + (inputs
> + `(("gettext" ,gnu-gettext)
Sure it shouldn't be in native-inputs? I'm guessing autogen uses it.
> +(define-public guile-emacs
> [...]
> + (substitute-keyword-arguments `(#:parallel-build? #f
A comment explaining why parallel builds are disabled would be good.
> + ;; Tests aren't passing for now.
> + ;; Obviously we should re-enable this!
> + #:tests? #f
Tests should generally always be enabled so the second line of the
comment would be redundant; just a nitpick. :-)
Otherwise looks good to me. Thanks!
Taylan
- [PATCH] Attempt at packaging guile-emacs (needs help), Christopher Allan Webber, 2015/05/10
- Re: [PATCH] Attempt at packaging guile-emacs (needs help), Mark H Weaver, 2015/05/10
- [PATCH] Add guile-emacs!, Christopher Allan Webber, 2015/05/13
- Re: [PATCH] Add guile-emacs!, Christopher Allan Webber, 2015/05/19
- Re: [PATCH] Add guile-emacs!, Taylan Ulrich Bayırlı/Kammer, 2015/05/19
- Re: [PATCH] Add guile-emacs!, Christopher Allan Webber, 2015/05/19
- Re: [PATCH] Add guile-emacs!, Taylan Ulrich Bayırlı/Kammer, 2015/05/19
- Re: [PATCH] Add guile-emacs!, Ludovic Courtès, 2015/05/20
Re: [PATCH] Add guile-emacs!, Feng Shu, 2015/05/23