Re: [PATCH] Add libsvm.

[Ricardo Wurmus]

>> +       (uri (string-append
>> +             "https://github.com/cjlin1/libsvm/archive/v";
>> +             (string-join (string-split version #\.) "") ".tar.gz"))
>
> (string-delete #\. version)

Oh, that's better, indeed!

> Also, please add a 'file-name' field so that the source filename in the
> store will be called *-libsvm-3.20.tar.gz instead of *-v320.tar.gz.

Ouch!  That's one of the things I usually do first (since I was made
aware of it), but this time I completely forgot about it.  Thanks for
the reminder!

>> +                     (zero? (system* "make" "lib"))))
>
> (zero? (system* "make"
>                 "-j" (number->string (parallel-job-count))
>                 "lib"))

[...]

> I tried building this, I noticed that the installed binaries (svm-train,
> svm-predict, and scm-scale) don't reference libsvm.so.2.  In the build
> output, I see no header files and no libsvm.so symlink, so I don't see
> how this library could be used.

It seems that this library is in fact only used by the Python module
which is built from the "python" subdir and for which I have prepared
another package.  I'll remove the library building phase from this
package and move it to the recipe for "python-libsvm".

My apologies for the confusion!  I'll send an updated patch soon.

~~ Ricardo