Re: PATCH: LibreOffice

[Ludovic Courtès]

Andreas Enge <address@hidden> skribis:

> The good news: Patch-shebanging the external xmlsec tarball does indeed not
> seem to be necessary, so I replaced the package recipe by a simple origin
> declaration. Does this internal variable need to be mentioned in the commit
> message?

Yes.

> The bad news: autoreconf is still needed for the xmlsec tarball.

Why is that?  Is it because LO’s own build system explicitly runs it, or
because some .am or .ac file is modified?  Would be nice to mention it
in a comment.

> From 80325ab4f875ee771fa5b80d6724f2a3f3f4c80c Mon Sep 17 00:00:00 2001
> From: Andreas Enge <address@hidden>
> Date: Fri, 29 May 2015 23:49:19 +0200
> Subject: [PATCH] gnu: Add LibreOffice.
>
> * gnu/packages/libreoffice.scm (xmlsec-src-libreoffice, libreoffice):
>   New variables.
>
> Co-authored-by: John Darrington <address@hidden>

[...]

> +  (origin
> +  (method url-fetch)

Please indent fields.

> +                   (string-append "external/tarballs/"
> +                     "1f24ab1d39f4a51faf22244c94a6203f-"
> +                     "xmlsec1-1.2.14.tar.gz"))

Funny.  :-)  That name is imposed by LO’s build system, right?

The rest looks good to me.  OK to push with these changes.

Thanks for the hard work!

Ludo’.