Re: [PATCH] Add st

[amirouche]

On 2015-06-09 16:22, Andreas Enge wrote:
> Hello,
>
> thanks for the submission! Just a partial review:
>
> On Tue, Jun 09, 2015 at 03:07:55PM +0200, address@hidden 
> wrote:
> > +       ("font-liberation5" ,font-liberation)))
>
> Typo? Drop "5"
>
> > +    (description
> > +     "Xterm is bloated and unmaintainable.  It has over 65K lines of 
> > code and
>
> Please write a more neutral description. Something like
> "St implements a simple and light-weight terminal emulator.  It 
> implements
> 256 colors, most VT10X escape sequences, utf8, X11 copy/paste,
> antialiased fonts (using fontconfig), fallback fonts, resizing,
> and line drawing."
> It is nicer to write what a programme does well than to complain about
> what others do poorly.

Agreed. I created a new patch with the changes you requested and I've 
run: ./pre-inst-env guix lint st.

0001-gnu-add-st.patch
Description: Text Data