guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHES] for Haskell packages


From: Ludovic Courtès
Subject: Re: [PATCHES] for Haskell packages
Date: Wed, 10 Jun 2015 21:42:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Federico would be the expert, but it looks good to me:

Eric Bavier <address@hidden> skribis:

> From 75a4305391cd246a6e8db5b11223f9ce243edd35 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Sat, 6 Jun 2015 06:38:58 -0500
> Subject: [PATCH 1/3] profiles: Search for ghc conf files only if package db
>  exists.
>
> This avoids having 'find-files' report warnings about searching in
> non-existent directories.
>
> * guix/profiles.scm (ghc-package-cache-file)[conf-files]: Only search
>   for *.conf files if the search directory exists.

OK, makes sense.

> From 08d67857d9726a2fddbc834c34caaae3e5a5d4f2 Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Sat, 6 Jun 2015 06:43:19 -0500
> Subject: [PATCH 2/3] profiles: Process ghc conf files only once.
>
> A package may be listed in the manifest inputs multiple times.  Avoid
> copying ghc *.conf files twice by deleting duplicates.
>
> * guix/profiles.scm (ghc-package-cache-file)[conf-files]: Delete
>   duplicate manifest inputs before copying conf files.

OK.

> From 480d18c683d3d74fab46578c93fb4cbf81d1a8be Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Sat, 6 Jun 2015 07:28:57 -0500
> Subject: [PATCH 3/3] build-system/haskell: install config for any package that
>  creates it.
>
> A Cabal package is allowed to declare an "empty" library, in an
> otherwise executable-only package, for the purpose of allowing Cabal
> to use it as a dependency for other packages.  See e.g. hspec-discover.
>
> * guix/build/haskell-build-system.scm (register): Unconditionally call
>   setup script with "register", and install any config file generated.

OK!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]