[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add powertabeditor.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH] Add powertabeditor. |
|
Date: |
Fri, 12 Jun 2015 21:39:28 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> From 18eaadd221e098dfd769cc6aa9c8920730c2674f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Thu, 4 Jun 2015 10:01:11 +0200
> Subject: [PATCH] gnu: Add powertabeditor.
>
> * gnu/packages/music.scm (powertabeditor): New variable.
> ---
> gnu/packages/music.scm | 98
> ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 98 insertions(+)
LGTM!
> + ;; CMake appears to lose the RUNPATH for some reason, so it has to be
> + ;; explicitly set with CMAKE_INSTALL_RPATH.
When you have time, it would be good to look at the build log to see all
the -rpath arguments that are passed. It’s a bit scary because it seems
CMake cannot remain under control, somehow. ;-)
Thank you!
Ludo’.