Re: [PATCHES] Add totem

[Ludovic Courtès]

Mark H Weaver <address@hidden> skribis:

> A few caveats: in order for totem to work properly, you must have
> several other packages installed in your profile.  I'm not entirely sure
> of the full set needed, but I guess it includes:
>
>   grilo
>   grilo-plugins
>   gstreamer
>   gst-plugins-base
>   gst-plugins-good
>   dconf
>
> You will also need to set the GRL_PLUGIN_PATH and GST_PLUGIN_SYSTEM_PATH
> environment variables as advised by "guix package --search-paths".

I can imagine why the plugins package need to be in the profile, but I
find the others more surprising.  Do you know what happens?  Are Grilo,
GStreamer, and DConf dlopened, or is it just to get the right search
path recommendation that they are needed?

> From 4bdac7f9e1ffeec6e3a2b26d366bfe8d71cd5ae2 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Sat, 20 Jun 2015 19:34:50 -0400
> Subject: [PATCH 1/3] gnu: Add grilo.
>
> * gnu/packages/gnome.scm (grilo): New variable.

LGTM.

> From ba786fa3d1d7896336dca3b364bb630142c30fa1 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Sat, 20 Jun 2015 21:09:54 -0400
> Subject: [PATCH 2/3] gnu: Add grilo-plugins.
>
> * gnu/packages/gnome.scm (grilo-plugins): New variable.

[...]

> +     `(#:make-flags (list (string-append "GRL_PLUGINS_DIR="
> +                                         %output
> +                                         "/lib/grilo-"
> +                                         ,(version-major+minor version)))
> +       ;; XXX FIXME: Investigate test failure:
> +       ;;   TEST: test_apple_trailers... (pid=8718)
> +       ;;     /apple-trailers/browse/count:
> +       ;;   ERROR:test_apple_trailers.c:88:test_browse_count: assertion 
> failed: (source)
> +       ;;   FAIL
> +       #:tests? #f))

Would it be OK to skip just this for now?  If that’s too much, we can
leave it for later.

> +    (synopsis "Framework for discovering and browsing media - Plugins")

Maybe “Plugins for the Grilo media discovery library”?

> From 2bbcefc85149fa4d6b8513de26fc4ba749e4111b Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <address@hidden>
> Date: Sat, 20 Jun 2015 18:26:34 -0400
> Subject: [PATCH 3/3] gnu: Add totem.
>
> * gnu/packages/gnome.scm (totem): New variable.

OK.

Thank you!

Ludo’.