guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/5] build: Add 'emacs-build-system'


From: Federico Beffa
Subject: Re: [PATCH 3/5] build: Add 'emacs-build-system'
Date: Thu, 25 Jun 2015 20:39:55 +0200

On Thu, Jun 25, 2015 at 1:57 PM, Ludovic Courtès <address@hidden> wrote:
> Federico Beffa <address@hidden> skribis:
>
>> On Mon, Jun 22, 2015 at 9:40 PM, Thompson, David
>> <address@hidden> wrote:
>>> On Mon, Jun 22, 2015 at 3:33 PM, Federico Beffa <address@hidden> wrote:
>>>>
>>>> But, my question was NOT: how can I see white spaces. Rather: is there
>>>> a Guix coding style "rule" which states that white spaces there are
>>>> undesired.
>>>>
>>>> I personally prefer to have them, because then, if I use M-up/down, I
>>>> move to the beginning/end of a whole top-level block, without stopping
>>>> at internal points and that's what I want most of the time.
>>>>
>>>> So, these spaces are not just coding artifacts, but have some use.
>>>
>>> There should be *no* trailing whitespace in submitted patches, and we
>>> should add a note about it to our contribution guidelines if it's not
>>> already there.
>
> +1
>
>> OK, I will delete those spaces then. But, I'm curious about the
>> rationale for such a rule.
>
> It’s mostly that no-trailing-whitespace is a simple canonical form.
> Having everyone follow it makes sure we don’t run into annoying patch
> conflicts due to whitespace, nor “noisy patches” that remove trailing
> spaces here and there.

Makes sense. Thanks for the explanation.

Fede



reply via email to

[Prev in Thread] Current Thread [Next in Thread]