Re: [PATCH 10/14] gnu: Add MUMPS.

[Ludovic Courtès]

address@hidden skribis:

> From: Eric Bavier <address@hidden>
>
> * gnu/packages/maths.scm (mumps, mumps-metis, mumps-openmpi)
>   (mumps-metis-openmpi): New variables.
> * gnu/packages/patches/mumps-build-parallelism.patch: New patch.
> * gnu-system.am (dist_patch_DATA): Add it.

ISTR that some time ago MUMPS included obfuscated code; I assume this is
no longer the case?

> +            (zero? (system* "make" "all"
> +                            (format #f "-j~a" (current-processor-count))))))

Rather ‘parallel-job-count’.

> +          (lambda* (#:key (exec-prefix '()) #:allow-other-keys)
> +            (with-directory-excursion "examples"
> +              (use-modules (srfi srfi-1))
> +              (every
> +               (lambda (prec type)
> +                 (use-modules (ice-9 popen))

Local ‘use-modules’ forms are not very nice (it’s not documented.)
Rather use:

  #:modules ((srfi srfi-1)
             (ice-9 popen)
             ,@%gnu-build-system-modules)

> +                 (let ((tester (apply open-pipe*
> +                                      `(,OPEN_WRITE
> +                                        ,@exec-prefix
> +                                        ,(string-append "./" prec
> +                                                        "simpletest"))))
> +                       (input  (open-input-file
> +                                (string-append "input_simpletest_" type))))
> +                   (begin
> +                     (dump-port input tester)
> +                     (close-port input)
> +                     (zero? (close-pipe tester)))))
> +               '("s" "d" "c" "z")
> +               '("real" "real" "cmplx" "cmplx")))))

Please add a comment saying that this does, to appease the reader.  ;-)

> +    (license license:public-domain)))

I think it’s CeCILL-C, see
<http://mumps.enseeiht.fr/index.php?page=dwnld>.

OK with these changes!

Thanks,
Ludo’.