Re: [PATCH 4/4] gnu: git: Add inputs for send-email.

[Eric Bavier]

On Mon, 29 Jun 2015 13:56:51 +0200
address@hidden (Ludovic Courtès) wrote:

> address@hidden skribis:
> 
> > From: Eric Bavier <address@hidden>
> >
> > * gnu/packages/version-control.scm (git)[inputs]: Add
> >   perl-authen-sasl, perl-net-smtp-ssl, and perl-io-socket-ssl.
> >   [arguments]: Add #:modules argument with srfi-1.  In 'split phase,
> >   wrap git-send-email.
> 
> [...]
> 
> > +      #:modules ((guix build gnu-build-system)
> > +                 (guix build utils)
> > +                 (srfi srfi-1))
> 
> Use %gnu-build-system-modules instead of listing modules explicitly.
> 
> > +              ;; Tell 'git-send-email' where perl modules are.
> > +              (wrap-program (string-append out
> > "/libexec/git-core/git-send-email")
> 
> It would be best to add a “send-email” output specifically for that,
> so we keep the size of the closure of “out” under control (2 MiB is
> still 10% of the size of “out”.)
> 
> > +                `("PERL5LIB" ":" prefix
> > +                  ,(map (lambda (o) (string-append o
> > "/lib/perl5/site_perl"))
> > +                        (delete-duplicates
> > +                         (list
> > +                          ,@(append-map
> > +                             (lambda (p)
> > +                               (let ((name (package-name p)))
> > +                                 `((assoc-ref inputs ,name)
> > +                                   ,@(map (match-lambda
> > +                                            ((label (? package?
> > _) . _)
> > +                                             `(assoc-ref inputs
> > +                                                         ,(string-append
> > name "/" label))))
> > +
> > (package-transitive-propagated-inputs p)))))
> > +                             `(,perl-authen-sasl
> > +                               ,perl-net-smtp-ssl
> > +                               ,perl-io-socket-ssl)))))))
> 
> Could you move the part of ,@ to a top-level procedure?

Updated patch attached.

`~Eric

0004-gnu-git-Add-inputs-for-send-email.patch
Description: Text document