guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add preseq.


From: Ludovic Courtès
Subject: Re: [PATCH] Add preseq.
Date: Wed, 01 Jul 2015 15:30:18 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Ricardo Wurmus <address@hidden> skribis:

> From 3ffe6847848f6ba107e0757728f1c6a6e7807d56 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 23 Jun 2015 10:54:00 +0200
> Subject: [PATCH] gnu: Add preseq.
>
> * gnu/packages/bioinformatics.scm (preseq): New variable.

[...]

> +              (snippet
> +               ;; Remove bundled samtools.  Leave the headers.
> +               '(for-each delete-file
> +                          (find-files "preseq-master/samtools"
> +                                      "\\.c$")))))

Why leave the headers?  Isn’t it risky to leave headers that may be
different from the Samtools that we’re actually linking against?

Otherwise LGTM.

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]