Re: [PATCH] setbfree: Fix build on MIPS64

[Mark H Weaver]

Ricardo Wurmus <address@hidden> writes:
> The attached patch should fix the build of setbfree on MIPS64.  The
> default value for OPTIMIZATIONS contains flags for x86 systems.

[...]

> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index 9e7e012..8f49f04 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -424,7 +424,12 @@ Editor.  It is compatible with Power Tab Editor 1.7 and 
> Guitar Pro.")
>         (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
>               (string-append "FONTFILE="
>                              (assoc-ref %build-inputs "font-bitstream-vera")
> -                            "/share/fonts/truetype/VeraBd.ttf"))
> +                            "/share/fonts/truetype/VeraBd.ttf")
> +             ;; Disable unsupported optimization flags on MIPS64
> +             ,@(if (string-prefix? "mips64" (or (%current-target-system)
> +                                                (%current-system)))
> +                   '("OPTIMIZATIONS=-ffast-math -fomit-frame-pointer -O3")
> +                   '()))

Can you tell what would happen on ARM systems, or other systems?
Depending on the answer to that question, it might be better to invert
the conditional and override OPTIMIZATIONS on any non-Intel system.

> I have not tested this as I don’t have access to a MIPS64 system.

I can test it on MIPS and ARM, but I'll wait to hear back on my question
above.

    Thanks!
      Mark