[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] scripts: substitute: Avoid infinite looping when updating th
From: |
Andy Patterson |
Subject: |
Re: [PATCH] scripts: substitute: Avoid infinite looping when updating the substitute list |
Date: |
Mon, 6 Jul 2015 20:08:52 -0400 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
Hi Ludo,
> Did you observe the problem when connecting to hydra.gnu.org, or was it
> another server? Did you have a way to reproduce it?
I was only connecting to hydra.gnu.org, and was using a default setup.
First I used the install image, and then on my current setup with a
version built from git. I was always able to reproduce the problem. I
think it may be that the network setup where I live is causing the
connection to always be closed, as it seems that no-one else has
experienced it.
> I’ve committed a slightly edited version of the patch where I factorized
> the call to PROC and changed the commit message to describe the changes
> at the source code level, in GNU change log style. (I hope this is fine
> with you.)
That's good, thanks! I wasn't too sure on the specifics of the GNU style
and mostly tried to imitate examples from the recent history. Seeing
what you've changed gives me a better idea of the correct style.
Cheers,
Andy