Re: [PATCH] gnu: pdf: Fix installing desktop files of zathura packages.

[Alex Kost]

Mark H Weaver (2015-07-07 18:07 +0300) wrote:

[...]
>>      (arguments
>>       `(#:make-flags
>>         `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> -          "PLUGINDIR=/lib/zathura" "CC=gcc")
>> +          "PREFIX=" "PLUGINDIR=/lib/zathura" "CC=gcc")
>
> It would be better to leave DESTDIR empty and set PREFIX=<%output>, so:

It wouldn't work for these packages.

>> -       `(,(string-append "DESTDIR=" (assoc-ref %outputs "out"))
>> +       `(,(string-append "PREFIX=" (assoc-ref %outputs "out"))
>
> There is a conceptual difference between PREFIX and DESTDIR: at install
> time, files are copied to ${DESTDIR}${PREFIX}, and then at run time
> files are expected to be at ${PREFIX}.  So in general, we don't want to
> use DESTDIR in Guix, and we want to set PREFIX to the output directory.

I know, but these zathura plugins do not provide configure stages, and
PREFIX is not even used in the manually written "Makefile"s.  PREFIX is
used in "config.mk" (which is included in a Makefile) to define LIBDIR
and DESKTOPPREFIX.

And due to Makefile things are installed in ${DESTDIR}${PLUGINDIR} and
${DESTDIR}${DESKTOPPREFIX}.

-- 
Alex