Re: [PATCH 14/15] scripts: environment: Add --container option.

[Ludovic Courtès]

"Thompson, David" <address@hidden> skribis:

> On Tue, Jul 7, 2015 at 10:35 AM, Ludovic Courtès <address@hidden> wrote:

>> Since this works without root privileges, what about adding a test in
>> tests/guix-environment.sh?
>>
>> Basically something similar to one of the existing tests, but
>> additionally checking from within the container that ‘id -u’ returns 0,
>> that ‘$$’ is 2, and that files outside of $PWD are not in the container.
>
> For some reason that I haven't figured out, the existing tests do not
> pass on my machine when I run:
>
>     make check TESTS=tests/guix-environment.sh
>
> I'm finding it difficult to debug our tests because the test runner
> eats backtraces and other useful info.

Could you post tests/guix-environment.log?  Normally it contains both
stdout and stderr, as well as all the shell lines that were executed.

>> Which reminds me: In a separate commit, it Would Be Nice to document our
>> minimal kernel requirements for the container functionality.  Could you
>> look into that?
>
> AFAIK the recommended minimal kernel version that folks should be
> using for this stuff is 3.13, and the kernel needs to be configured
> with that DEVPTS_MULTIPLE_INSTANCES flag.  Where would you put this
> information?

The DEVPTS_MULTIPLE_INSTANCES thing should probably go in “Setting Up
the Daemon.”

The rest could maybe go to a “Container Support” section under
“Installation” that would be referenced from “Requirements” (where
optional dependencies are listed)?  Any better idea?

Thanks,
Ludo’.