[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add seqtk.
From: |
John Darrington |
Subject: |
Re: [PATCH] Add seqtk. |
Date: |
Sat, 18 Jul 2015 11:07:48 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Sat, Jul 18, 2015 at 05:51:01PM +1000, Ben Woodcroft wrote:
On 24/06/15 22:09, Mark H Weaver wrote:
>However, there's a bigger problem here. Some of the code is not clearly
>licensed or has invalid copyright notices:
>
>* The copyright notice on kstring.h lacks copyright dates.
>
>* The copyright dates in seqtk.c and LICENSE are incorrect
> ("20082-2012").
>
>* ksw.h and trimadap.c lack any copyright notice at all. The mere
> presence of a LICENSE file is not enough, especially given the lack of
> any statement about the code license in the README.
>
>Would you be willing to ask the author to fix these issues?
I did this almost a month ago
https://github.com/lh3/seqtk/pull/60
But no response as yet. I think the common sense here is that it
is expat licensed, WDYT? It would be a shame to exclude this
software as it is quite well used in bioinformatics generally,
but I'm happy to defer to your decision.
When I look at that url, I don't see that you have asked anybody anything.
The message isn't addressed to anyone in particular; the salutation is
merely "Hi". Also, it poses no question. It just make a (very weak) statement,
including the words "seem to be" and "unsure". I'm not surprised nobody has
replied. Probably nobody thinks it affects them.
I suggest that you post a followup message mentioning explicitly:
* To whom it is addressed,.
* What is missing, and how to correct it.
* Why this is a problem.
* That you would be willing to help in the effort to fix it (assuming that
you are of course).
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature