[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add hoedown.
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCH] gnu: Add hoedown. |
Date: |
Sun, 19 Jul 2015 19:19:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) |
David Thompson <address@hidden> writes:
> Here's a package recipe for a Markdown library written in C. I want to
> try to make Guile bindings for it with the FFI.
Nice idea!
> +(define-module (gnu packages markdown)
> + #:use-module (guix licenses)
> + #:use-module (guix packages)
> + #:use-module (guix download)
> + #:use-module (guix packages)
> + #:use-module (guix build-system gnu)
> + #:use-module (gnu packages python)
> + #:use-module (gnu packages web))
guix packages is added two times. Maybe "prefix:" for licences to be
safe ?
> + (substitute* '("Makefile")
> + (("/usr/local")
> + (assoc-ref outputs "out")))
No need to use a list of files here. I noticed some warnings in the
compilation process which can be fixed like this.
--8<---------------cut here---------------start------------->8---
(substitute* "Makefile"
(("-ansi") "-std=c99")
(("/usr/local") (assoc-ref outputs "out")))
--8<---------------cut here---------------end--------------->8---
> + (native-inputs
> + `(("python" ,python-2)
> + ("tidy" ,tidy)))
perl is needed in native-inputs for "test/MarkdownTest_1.0.3/MarkdownTest.pl"
Otherwise LGTM! (if i'm entitled to ;))
I will send a patch for moving the "markdown" package to this new file after
that.
--
Mathieu Lirzin