Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system

[Ludovic Courtès]

Pjotr Prins <address@hidden> skribis:

> On Sat, Jul 18, 2015 at 05:20:28PM +0200, Ludovic Courtès wrote:
>> >      (zero? (system* "gem" "install" "--local"
>> > -                    "--bindir" (string-append out "/bin")))))
>> > +                    "--bindir" (string-append out "/bin") "--"
>> > +                    (string-join (cond (null? 
>> > gem-flags)('())(gem-flags)))))))
>> 
>> , and ‘gem-flags’ is not a procedure so it cannot be called.  So
>> I’ve changed that, also removing the “--”.  Pushed as 6e9f291.
>
> The "--" is required when gem-flags is passed in. It is optional when
> gem-flags is empty. Do you think gem authors should always prepend the
> "--" in front of the other options? I would think it is a builder
> thing if we can abstract it away. Right? If that is so, we can leave it
> there since it is harmless if gem-flags is empty.

My guess is that there are options like --bindir (maybe “--docdir”?) for
which “--” does not need to be added, and others for which it is
needed.  That’s why I left it out (also: users can easily add “--” but
cannot remove it if it’s hard-coded.)

Now, Dave and you definitely know this better than me, so I’ll rely on
your judgment.  Thoughts?

Ludo’.