guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: cross-base: Disable libcilkrts in cross-gcc.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: cross-base: Disable libcilkrts in cross-gcc.
Date: Sun, 19 Jul 2015 23:16:31 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Manolis Ragkousis <address@hidden> skribis:

> From 37d96c984baeb4e2857d8338fae3e9459140e8f5 Mon Sep 17 00:00:00 2001
> From: Manolis Ragkousis <address@hidden>
> Date: Sun, 19 Jul 2015 18:16:51 +0300
> Subject: [PATCH] gnu: cross-base: Disable libcilkrts in cross-gcc.
>
> * gnu/packages/cross-base.scm (cross-gcc-arguments): Add 
> "--disable-libcilkrts".

We'll keep it out of master until after 0.8.3 if you don’t mind.

> +                             `( ;; Disable libcilkrts because it causes the
> +                                ;; build to fail when targeting the Hurd.
> +                               "--disable-libcilkrts")

The comment should be more specific: it should make it clear that
libcilkrts is not ported to GNU/Hurd (“causes the build to fail” sounds
like “something went wrong but we didn’t bother”, which is not the case
here!).

Ideally we’d disable it for GNU/Hurd targets only, but OTOH, I think we
can safely assume that nobody will notice that Cilk support is missing...

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]