Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system

[Pjotr Prins]

On Sun, Jul 19, 2015 at 10:44:18PM +0200, Ludovic Courtès wrote:
> > On Sat, Jul 18, 2015 at 05:20:28PM +0200, Ludovic Courtès wrote:
> >> >      (zero? (system* "gem" "install" "--local"
> >> > -                    "--bindir" (string-append out "/bin")))))
> >> > +                    "--bindir" (string-append out "/bin") "--"
> >> > +                    (string-join (cond (null? 
> >> > gem-flags)('())(gem-flags)))))))

> My guess is that there are options like --bindir (maybe “--docdir”?) for
> which “--” does not need to be added, and others for which it is
> needed.  That’s why I left it out (also: users can easily add “--” but
> cannot remove it if it’s hard-coded.)

OK. Makes sense. Arguably, in that case the default options (--local,
--bindir) should be overridable too. But, as they are sensible, let's
leave it the way it is now. We'll just add "--" for every gem (it is
actually a pass-through of options to the underlying build system, so
I could have named it ext-flags, or something, and have a separate
gem-flags).

But I think the current version is fine. Next up the ruby-nokogiri
package.

Pj.