[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add aragorn.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] Add aragorn. |
Date: |
Tue, 21 Jul 2015 15:40:35 +0200 |
Ben Woodcroft <address@hidden> writes:
> +(define-public aragorn
> + (package
> + (name "aragorn")
> + (version "1.2.36")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> +
> "http://mbio-serv2.mbioekol.lu.se/ARAGORN/Downloads/aragorn"
> + version ".tgz"))
> + (file-name (string-append name "-" version ".tgz"))
Is this really necessary? The version is included in the tarball name,
it just doesn’t look like “name-version.tgz” but like
“nameversion.tgz”. I think it could be left off.
> + (sha256
> + (base32
> + "1dg7jlz1qpqy88igjxd6ncs11ccsirb36qv1z01a0np4i4jh61mb"))))
> + (build-system gnu-build-system)
> + (arguments
> + `(#:tests? #f ; there are no tests
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'build
> + (lambda _
> + (zero? (system* "gcc"
> + "-O3"
> + "-ffast-math"
> + "-finline-functions"
> + "-o"
> + "aragorn"
> + (string-append
> + "aragorn" ,version ".c")))))
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append
> + (assoc-ref outputs "out") "/bin"))
> + (man (string-append
> + (assoc-ref outputs "out") "/share/man/man1")))
> + (mkdir-p bin)
> + (copy-file "aragorn"
> + (string-append bin "/aragorn"))
> + (mkdir-p man)
> + (copy-file "aragorn.1"
> + (string-append man "/aragorn.1")))
> + #t)))))
> + (home-page "http://mbio-serv2.mbioekol.lu.se/ARAGORN")
> + (synopsis
> + "Detect tRNA, mtRNA and tmRNA genes in nucleotide sequences")
> + (description
> + "Aragorn identifies transfer RNA and transfer-messenger RNA sequences
> from
> +nucleotide sequences, based on homology to known tRNA consensus sequences and
> +RNA structure. It output the secondary structure of the predicted RNA.")
There is a space missing at the end of the sentence. Double-spacing
should be used.
> + (license license:gpl2)))
> +
Other than that it looks fine to me! Thanks!
~~ Ricardo