[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] python2-ansible, python-ccm and dependencies
From: |
Alex Kost |
Subject: |
Re: [PATCH] python2-ansible, python-ccm and dependencies |
Date: |
Sat, 25 Jul 2015 12:28:18 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Eric Dvorsak (2015-07-24 19:21 +0300) wrote:
> I added the following package definitions to python.scm :
>
> - python2-ansible
> - python-passlib
> - python-py-bcrypt
> - python-paramiko
> - python-httplib2
> - python-ecdsa
> - python-ccm
>
> This is my first commit ever so if I did something wrong or missed a
> step in the process please let me know so I can improve for the next
> ones.
>
> Eric Dvorsak.
Hello and welcome! We prefer a single patch per package and the commit
messages should look like this:
--8<---------------cut here---------------start------------->8---
gnu: Add python2-ansible.
* gnu/packages/python.scm (python2-ansible): New variable.
--8<---------------cut here---------------end--------------->8---
See also other python commits.
And some quick notes:
> + (home-page "http://ansible.com/")
> + (synopsis "Radically simple IT automation")
> + (description "Radically simple IT automation")
Please, add periods in the end of descriptions. And usually
descriptions should be more verbose than synopses.
> + (license gpl3)))
'gpl3+'. 'gpl3' shouldn't even work in this module.
> + (home-page "http://passlib.googlecode.com")
This page says the project has moved. Perhaps
<https://pythonhosted.org/passlib/>?
> + (synopsis
> + "Comprehensive password hashing framework supporting over 30 schemes")
> + (description
> + "Comprehensive password hashing framework supporting over 30 schemes")
> + (license bsd-3))
> + )
(license bsd-3)))
Please do not put a single parenthesis on a separate line.
> +(define-public python-paramiko
> + (package
> + (name "python-paramiko")
> + (version "1.15.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://pypi.python.org/packages/source/p/paramiko/paramiko-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "0mbfzm9zlrz6mla9xakrm8wkll3x035f9rj3c5pbgjzfldqscmjg"))))
> + (build-system python-build-system)
> + (inputs
> + `(("python-ecdsa" ,python-ecdsa)
> + ("python-pycrypto" ,python-pycrypto)
> + ("python-setuptools" ,python-setuptools)))
> + (propagated-inputs
> + `(("python2-pycrypto" ,python2-pycrypto)))
Did you mean "python-pycrypto" (not "python2-pycrypto")?
--
Alex
- [PATCH] python2-ansible, python-ccm and dependencies, Eric Dvorsak, 2015/07/24
- Re: [PATCH] python2-ansible, python-ccm and dependencies,
Alex Kost <=
- Re: [PATCH] python2-ansible, python-ccm and dependencies, Ricardo Wurmus, 2015/07/25
- Re: [PATCH] python2-ansible, python-ccm and dependencies, Eric Dvorsak, 2015/07/25
- Re: [PATCH] python2-ansible, python-ccm and dependencies, Alex Kost, 2015/07/26
- Re: [PATCH] python2-ansible, python-ccm and dependencies, Eric Dvorsak, 2015/07/26
- Re: [PATCH] python2-ansible, python-ccm and dependencies, Alex Kost, 2015/07/29
- Re: [PATCH] python2-ansible, python-ccm and dependencies, Alex Kost, 2015/07/31