Re: [PATCH] python2-ansible, python-ccm and dependencies

2015-07-26 11:56 GMT+02:00 Alex Kost <address@hidden>:

Eric Dvorsak (2015-07-25 22:58 +0300) wrote:

> Thank you Ricardo and Alex for taking the time to review and comment my
> patch. I edited it to take your advices into account. I hope I did not miss
> anything this time

Please add the following line to "python.scm":

;;; Copyright © 2015 Eric Dvorsak <address@hidden>

I think you can do it in the first patch.

[...]
> + (synopsis "Cassandra Cluster Manager")
> + (description "A script/library to create, launch and remove an Apache Cassandra cluster on localhost.")

Please, do not use long lines (more than 72-78 chars). If you use
Emacs, you may just "M-q" inside descriptions.

[...]
> +(define-public python2-ansible
> + (package
> + (name "python2-ansible")
> + (version "1.9.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://pypi.python.org/packages/source/a/ansible/ansible-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "007fzgsqaahb0y4gjdxxmir9kcni7wph2z14jhqgpz88idrz8pn2"))))
> + (build-system python-build-system)
> + (native-inputs
> + `(("python2-setuptools" ,python2-setuptools)
> + ("python2-pycrypto" ,python2-pycrypto)
> + ("python2-httplib2" ,python2-httplib2)
> + ("python2-passlib" ,python2-passlib)
> + ("python2-nose" ,python2-nose)
> + ("python2-mock" ,python2-mock)
> + ("python2-jinja2" ,python2-jinja2)
> + ("python2-pyyaml" ,python2-pyyaml)
> + ("python2-paramiko" ,python2-paramiko)))
> + (inputs
> + `(("python2-pycrypto" ,python2-pycrypto)
> + ("python2-jinja2" ,python2-jinja2)
> + ("python2-pyyaml" ,python2-pyyaml)
> + ("python2-paramiko" ,python2-paramiko)))
> + (arguments
> + `(#:python ,python-2)) ; incompatible with Python 3
> + (home-page "http://ansible.com/")
> + (synopsis "Radically simple IT automation")
> + (description "Ansible is a radically simple IT automation system. It handles configuration-management, application deployment, cloud provisioning, ad-hoc task-execution, and multinode orchestration - including trivializing things like zero downtime rolling updates with load balancers.")
> + (license gpl3)))

I think it should be 'gpl3+'. AFAICS
<https://github.com/ansible/ansible/blob/devel/COPYING> is a usual GPL
license <http://www.gnu.org/licenses/gpl.txt> which has "or any later
version" in it, so we use 'gpl3+' for this.

Otherwise, the patches look good to me, perhaps the others will notice
more. I can only confirm that the packages built successfully here.

--
Alex

From:	Eric Dvorsak
Subject:	Re: [PATCH] python2-ansible, python-ccm and dependencies
Date:	Sun, 26 Jul 2015 14:05:09 +0200