Re: [PATCH 2/4] build: Produce 'guix-config' instead of using compile-time tricks.

[Alex Kost]

Mathieu Lirzin (2015-07-28 00:48 +0300) wrote:

[...]
> +(defconst guix-prefix
> +  "@prefix@")
> +
> +(defconst guix-emacs-ui-dir
> +  "@emacsuidir@")

I think this constant is useless in this form since its value will be
"${prefix}/share/guile/site/2.0/guix/emacs".  What about making it:

(defconst guix-emacs-ui-dir
  (replace-regexp-in-string "${prefix}" guix-prefix "@emacsuidir@"))

And to leave:

(defvar guix-load-path guix-emacs-ui-dir
  "Directory with scheme files for \"guix.el\" package.")

in "guix-backend.el"?

> +
> +(defconst guix-local-state-dir
> +  "@guix_localstatedir@"oo)
> +
> +(provide 'guix-config)
> +
> +;;; guix-config.el ends here
> diff --git a/emacs/guix-init.el b/emacs/guix-init.el
> new file mode 100644
> index 0000000..353bb27
> --- /dev/null
> +++ b/emacs/guix-init.el
> @@ -0,0 +1,20 @@
> +(require 'guix-config)

I think requiring 'guix-config' is not needed in "guix-init.el".

The rest looks good to me.

-- 
Alex