guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xscreenshot and imagefile


From: Mark H Weaver
Subject: Re: [PATCH] xscreenshot and imagefile
Date: Wed, 29 Jul 2015 11:51:19 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Orchidaceae Phalaenopsis <address@hidden> writes:
> * xscreenshot which takes a screenshot and saves it as .if format
> * imagefile which contains a few programs to convert .if to gif, png

Honestly, I'm doubtful whether our users will have any interest in these
programs.  I'm not aware of any other GNU/Linux distribution that
includes them.  I've never heard of the .if format before, and
apparently the only purpose for this 'imagefile' tool will be to convert
the output of 'xscreenshot' into something that other programs can
understand.  There already exist other established, simple formats like
'xpm' for when a simple, transparent, and lossless format is desired.

Also, there are several other existing programs called 'xscreenshot'.

> From ee624abf3aada75b5fa234eec0b28fd5e2c561b0 Mon Sep 17 00:00:00 2001
> From: Alf Levan <address@hidden>
> Date: Mon, 27 Jul 2015 18:34:44 +0100
> Subject: [PATCH 1/2] gnu: Add xscreenshot.
>
> * gnu/packages/suckless.scm (xscreenshot): New variable.

Do these programs have any relationship to suckless.org other than
apparently being guided by a similar philosophy?

> +(define-public xscreenshot
> +  (package
> +    (name "xscreenshot")
> +    (version "1.0")
> +    (source (origin
> +          (method git-fetch)
> +          (uri (git-reference
> +                (url "git://git.2f30.org/xscreenshot")
> +                (commit "cb8ad23")))
> +          (sha256
> +           (base32
> +            "1sqhxybzi8mmb0jg78swp0vpbdiqhckd283k33lfffsd0lkgch88"))))

Is there any basis for choosing the version number "1.0" for this
commit?  Apparently upstream produces no releases, and there are no tags
in the git repo either.

> +(define-public imagefile
> +  (package
> +    (name "imagefile")
> +    (version "1.0")

Ditto.

> +    (source (origin
> +          (method git-fetch)
> +          (uri (git-reference
> +                (url "git://git.2f30.org/imagefile")
> +                (commit "787ebb0")))
> +          (sha256
> +           (base32
> +            "1lk8wk8qzdqn1dw37vk7p2v63mj94fpc0h5dvjqlzdsz2cblgzcb"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:tests? #f ; no tests
> +       #:make-flags (list "CC=gcc"
> +                          (string-append "PREFIX=" %output))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))))
> +    (inputs
> +     `(("libx11" ,libx11)
> +       ("libpng" ,libpng)
> +       ("giflib" ,giflib)
> +       ("libjpeg" ,libjpeg)))
> +    (native-inputs `(("pkg-config" ,pkg-config)))
> +    (home-page "http://git.2f30.org/xscreenshot/";)

This is the wrong home-page URL.

> +    (synopsis "Utilities to convert imagefile format")
> +    (description
> +     "The imagefile-format is meant to be parsed easily and used to pipe 
> images losslessly.")
> +    (license license:isc)))

Anyway, I'm not sure we have any interest in these programs.
What do other people think?

    Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]