guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: file-systems: Allow for bind mounting regular files.


From: Thompson, David
Subject: Re: [PATCH] build: file-systems: Allow for bind mounting regular files.
Date: Sun, 2 Aug 2015 08:43:10 -0400

On Sun, Aug 2, 2015 at 8:10 AM, Alex Kost <address@hidden> wrote:
> David Thompson (2015-08-01 22:17 +0300) wrote:
>
>> diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
>> index c58d23c..f0d6f70 100644
>> --- a/gnu/build/file-systems.scm
>> +++ b/gnu/build/file-systems.scm
>> @@ -305,6 +305,10 @@ the following:
>>                 fsck code device)
>>         (start-repl)))))
>>
>> +(define (regular-file? file-name)
>> +  "Return #t if FILE-NAME is a regular file."
>> +  (eq? (stat:type (stat file-name)) 'regular))
>
> There are similar procedures in (guix build utils): 'directory-exists?',
> 'executable-file?' and 'symbolic-link?'.  So I think it is better to put
> 'regular-file?' there.  WDYT?

Sure, that makes sense.  Done.

- Dave

Attachment: 0001-build-file-systems-Allow-for-bind-mounting-regular-f.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]