[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add VPN client ike.
|
From: |
Alex Kost |
|
Subject: |
Re: [PATCH] Add VPN client ike. |
|
Date: |
Tue, 04 Aug 2015 13:26:56 +0300 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus (2015-08-03 16:41 +0300) wrote:
> +(define-public ike
> + (package
> + (name "ike")
> + (version "2.2.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://www.shrew.net/download/ike/ike-";
> + version "-release.tbz2"))
> + (sha256
> + (base32
> + "0mvvmfc7ldgq48x75khr98d52jvg24zzlyinmzsihy2ly4g2ziq5"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:tests? #f ; no "check" target
> + #:out-of-source? #f
> + #:configure-flags (list (string-append "-DSBINDIR="
> + (assoc-ref %outputs "out")
> + "/sbin")
> + (string-append "-DBINDIR="
> + (assoc-ref %outputs "out")
> + "/bin")
> + (string-append "-DETCDIR="
> + (assoc-ref %outputs "out")
> + "/etc")
> + (string-append "-DLIBDIR="
> + (assoc-ref %outputs "out")
> + "/lib")
> + (string-append "-DMANDIR="
> + (assoc-ref %outputs "out")
> + "/man/man1/")
> + "-DNATT=YES")))
It seems redundant to reevaluate (assoc-ref %outputs "out") every time.
What about wrap it into 'let'?, or maybe just to use following form:
(list (string-append "-DSBINDIR=" %output "/sbin")
(string-append "-DBINDIR=" %output "/bin")
(string-append "-DETCDIR=" %output "/etc")
(string-append "-DLIBDIR=" %output "/lib")
(string-append "-DMANDIR=" %output "/man/man1/")
"-DNATT=YES")
--
Alex