Re: [PATCH 7/7] emacs: Add 'guix-devel-build-current-package-definition'.

[Alex Kost]

Ludovic Courtès (2015-08-18 17:17 +0300) wrote:

> Alex Kost <address@hidden> skribis:
>
>> Suggested by Ludovic Courtès <address@hidden>.
>>
>> * emacs/guix-guile.el (guix-guile-definition-regexp): New variable.
>>   (guix-guile-current-definition): New function.
>> * emacs/guix-devel.el (guix-devel-build-current-package-definition): New
>>   command.
>> * doc/emacs.texi (Emacs Development): Document it.
>
> The subject line is incorrect.

Ah, indeed!  It should be:

  emacs: Add 'guix-devel-build-current-package-definition'.

Is that OK?

>> address@hidden M-x guix-devel-build-current-package-definition
>> +Build package defined by the current variable definition.  If you
>> +modified the current package definition, don't forget to reevaluate it
>> +before calling this command (for example, with @kbd{C-M-x} (@pxref{To
>> +eval or not to eval,,, geiser, Geiser User Manual})).
>
> Maybe mention that, unfortunately, it will block until the command
> completes?

Yes, sure.

> Also, what about suggesting or even defining a key binding for this one?
> It sounds very useful.

There is an example of defining a key binding for a command in this
section.  As for the real defining, not sure if it is worth, but yeah,
why not.  We may define 'guix-minor-mode', for example, with
guix-specific key bindings.  But I don't know what bindings to use:
'geiser-mode' already binds many commands to [C-c …].  Perhaps to put
the additional keys in [C-c g …]?

-- 
Alex