guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] guix: lint: Check for version-only origin file names.


From: Eric Bavier
Subject: Re: [PATCH] guix: lint: Check for version-only origin file names.
Date: Mon, 24 Aug 2015 19:10:24 -0500

On Mon, 24 Aug 2015 19:02:11 -0400
Mark H Weaver <address@hidden> wrote:

> address@hidden writes:
> 
> > From: Eric Bavier <address@hidden>
> >
> > * guix/scripts/lint.scm (check-source): Emit warning if source filename
> >   contains only the version of the package.
> 
> This is not a proper review, but I just wanted to add that another
> common case is for the filename to start with "v" followed by the
> version number, e.g. "v3.2.0.tar.gz", so it would be good to check for
> that too.

Indeed.  Attached is an updated patch, with tests and documentation
too! :)
 
> Thank you for working on it!

My pleasure.

`~Eric

Attachment: 0001-guix-lint-Check-for-version-only-origin-file-names.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]