Re: [PATCH 1/2] gnu: Add eyed3.

[Efraim Flashner]

On Mon, 24 Aug 2015 18:48:04 -0400
Mark H Weaver <address@hidden> wrote:

> Efraim Flashner <address@hidden> writes:
> 
> > On Thu, 20 Aug 2015 17:50:10 +0800
> > 宋文武 <address@hidden> wrote:
> >
> >> Efraim Flashner <address@hidden> writes:
> >> 
> >> eyeD3 is both a tool and python library, I wonder whether
> >> 'python-eyed3' fits better.
> >
> > 'python-eyed3' is probably a better name. I wonder perhaps as a python
> > library it should be in python.scm instead of mp3.scm. Anyone have a
> > suggestion on that front?
> 
> If it includes a library, then I think it should be named
> 'python-eyed3'.  This is our usual convention, and it has the advantage
> that we can add 'python2-eyed3' later, in case someone wants it.

Changed the package to python-eyed3 and moved it to python.scm.

> 
> Also, your mail client seems to have applied word-wrapping to the patch,
> so some of the "+" signs have been wrapped into the description.  This
> is what I see:
> 
> --8<---------------cut here---------------start------------->8---
> +    (description
> +     "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3
> files. +It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard.
> Additionally it +displays several information about the file such as length
> and bitrate from an +MP3 file.")
> --8<---------------cut here---------------end--------------->8---
> 
> This makes it difficult for us to apply it, since we'd have to fix it up
> by hand.  Can you persuade your mail client to avoid word-wrapping?  You
> could make it an attachment if needed.
> 
>      Thanks!
>        Mark

I've turned off line wrapping so there shouldn't be any more wrapping in my 
email messages.

-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

0001-gnu-Add-python-eyed3.patch
Description: Text Data

pgpPcfedqn2pw.pgp
Description: OpenPGP digital signature