Re: [PATCH] gnu: Add cabal-install.

[Ludovic Courtès]

Siniša Biđin <address@hidden> skribis:

> From 0d321519e9bce55956b2989c7814e36a9abe9421 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Sini=C5=A1a=20Bi=C4=91in?= <address@hidden>
> Date: Tue, 18 Aug 2015 16:19:11 +0200
> Subject: [PATCH] gnu: Add cabal-install.
>
> * gnu/packages/haskell.scm (cabal-install): New variable.

[...]

> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm

Please add a copyright line for yourself.

> +    (arguments `(#:tests? #f))

Could you add a comment above explaining why tests are disabled?  (We
generally avoid that unless there’s a good reason, sometimes because
running the tests would be unnecessarily complex.)

> +    (synopsis "The command-line interface for Cabal and Hackage.")

Remove “The” and the period (and make sure to run ‘guix lint’ ;-)).

Otherwise LGTM.

Could you send an updated patch?

Thanks,
Ludo’.