Re: [PATCH] gnu: services: Add nginx-service.

[Thompson, David]

On Tue, Aug 25, 2015 at 5:35 PM, Ludovic Courtès <address@hidden> wrote:
> "Thompson, David" <address@hidden> skribis:
>
>> On Tue, Aug 18, 2015 at 11:58 AM, Ludovic Courtès <address@hidden> wrote:
>>> "Thompson, David" <address@hidden> skribis:
>>>
>>>> From c2da6c04eb1a12d0ee2f56a3954673f3bddc122b Mon Sep 17 00:00:00 2001
>>>> From: David Thompson <address@hidden>
>>>> Date: Sun, 2 Aug 2015 23:29:53 -0400
>>>> Subject: [PATCH] gnu: services: Add nginx-service.
>>>>
>>>> * gnu/services/web.scm: New file.
>>>> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
>>>
>>> [...]
>>>
>>>> +(define (default-nginx-config log-directory run-directory)
>>>> +  (text-file* "nginx.conf"
>>>> +              "user nginx nginx;\n"
>>>> +              "pid " run-directory "/pid;\n"
>>>> +              "error_log " log-directory "/error.log info;\n"
>>>> +              "http {\n"
>>>> +              "    access_log " log-directory "/access.log;\n"
>>>> +              "    root /var/www;\n"
>>>> +              "    server {}\n"
>>>> +              "}\n"
>>>> +              "events {}\n"))
>>>> +
>>>> +(define* (nginx-service #:key (nginx nginx)
>>>> +                        (log-directory "/var/log/nginx")
>>>> +                        (run-directory "/var/run/nginx")
>>>> +                        (config-file
>>>> +                         (default-nginx-config log-directory 
>>>> run-directory)))
>>>
>>> There’s this annoying thing that here ‘config-file’ is a monadic value
>>> when we’d instead prefer a “file-like object.”
>
> But it just occurred to me that you could write:
>
>   (define (default-nginx-config log-directory run-directory)
>     (plain-file "nginx.conf"
>                 (string-append ...)))
>
> Problem solved!

Good idea, thanks!  I made this change, added a new section to the
docs, and pushed.

- Dave