Re: [PATCH 1/3] gnu: Add llfuse.

[Alex Kost]

Leo Famulari (2015-08-26 20:16 +0300) wrote:

> +(define-public llfuse
> +  (package
> +   (name "llfuse")
> +   (version "0.40")
> +   (source (origin
> +            (method url-fetch)
> +            (uri (string-append
> +                  "https://bitbucket.org/nikratio/python-llfuse/downloads/";
> +                  "llfuse-" version ".tar.bz2"))
> +            (sha256
> +             (base32 
> "0mx87n6j2g63mgiimjqn0gj6jgqfdkc04xkxc56r1azjlqji32zf"))))
> +   (build-system python-build-system)
> +   (inputs `(("fuse" ,fuse)
> +             ("attr" ,attr)))
> +   (native-inputs `(("pkg-config" ,pkg-config)))
> +   (synopsis "Python bindings for FUSE")
> +   (description "Python-LLFUSE is a set of Python bindings for the low level
> +FUSE API.  It requires at least FUSE 2.8.0 and supports both Python 2.x and
> +3.x.")

IMHO mentioning a version of fuse is not needed.  And IIUC this package
provides a python3 library, so I would also remove "supports both …".

> +   (home-page "https://bitbucket.org/nikratio/python-llfuse/";)
> +   (license lgpl2.0)))

It should be 'lgpl2.0+' as the LICENSE file says "or (at your option)
any later version".

Also I think it is better to put this package in "python.scm" as it just
contains some general python library.  But I'm not an expert here, so
better wait for comments of other people.

But I would name it 'python-llfuse' and would also add 'python2-llfuse'
package (bug again: I didn't make a single python package).

-- 
Alex