Re: [PATCH] Add Frescobaldi.

[Ricardo Wurmus]

Ludovic Courtès <address@hidden> writes:
>> AFAIK a patch to update fontconfig was submitted for the core-updates
>> branch already.
>
> There’s no such thing in ‘core-updates’.  However, one could set a
> ‘fontconfig-update’ branch and update Fontconfig and possibly related
> libraries.  We could merge it in ‘master’ more quickly than
> ‘core-updates’.

The patch I was referring to has been submitted here, but apparently it
hasn’t been committed yet:

    http://lists.gnu.org/archive/html/guix-devel/2015-08/msg00225.html

>> * gnu/packages/pdf.scm (python-poppler-qt4): New variable.
>
> [...]
>
>> +    (native-inputs
>> +     `(("qt-4" ,qt-4)
>
> Native?  If it’s for one of the binaries, such as ‘qmake’, please
> mention it in a margin comment.

Oh, that was a mistake and isn’t actually needed.  I removed it.
(That’s an embarrassingly big input to forget about.)

>> +    (synopsis "Python bindings for libpoppler-qt4")
>
> “Poppler-Qt4” maybe?

Okay.

>> +    (description
>> +     "This package provides Python bindings for the Poppler Qt4 interface
>> +library.")
>
> “... for the Qt4 interface of the Poppler PDF rendering library.”
> So that at least “PDF” shows up in the description.
>
> OK with these changes.

Okay.

>> * gnu/packages/music.scm (frescobaldi): New variable.
>
> [...]
>
>> +    (home-page "http://www.frescobaldi.org/";)
>> +    (synopsis "LilyPond sheet music text editor")
>> +    (description
>> +     "Frescobaldi is a LilyPond sheet music text editor with syntax
>> +highlighting and automatic completion.")
>
> Would be nice to mention a couple of features, like: “Among other
> things, it can render scores next to the source, can capture input from
> MIDI or read MusicXML and ABC files, has a MIDI player for
> proof-listening, and includes a documentation browser.”
>
> OK with this change.

I worked in the suggested changes and pushed.  Thanks a lot for the
review!

~~ Ricardo