[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: Fix potential type error when generating human-friend
From: |
Mark H Weaver |
Subject: |
Re: [PATCH] build: Fix potential type error when generating human-friendly byte count strings. |
Date: |
Wed, 09 Sep 2015 22:42:55 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Steve Sprang <address@hidden> writes:
> This is a follow up tweak to my previous "progress bar" patch. With a
> really slow throughput it's possible to get fractional sub-KiB byte
> counts, so I added some additional number massaging.
Sounds good! Looks good to me except for a few minor nits on this
auxiliary procedure:
> +(define (number->integer n)
> + "Given an arbitrary number N, round it and return the exact result."
> + (inexact->exact (round n)))
How about calling it "nearest-exact-integer"? Also, it makes sense only
for real numbers, not arbitrary numbers, and the variable name N is
conventionally used to denote natural numbers, and X for real numbers.
So, how about naming the argument 'x', and using something closer to the
following docstring:
"Given a real number X, return the nearest exact integer, with ties
going to the nearest exact even integer."
Otherwise, looks good to me. Can you send an updated patch?
Mark