[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] guix: Move package-transitive-propagated-labels* and pac
From: |
Eric Bavier |
Subject: |
Re: [PATCH 5/6] guix: Move package-transitive-propagated-labels* and package-propagated-input-refs to (guix packages). |
Date: |
Thu, 10 Sep 2015 03:33:04 -0500 |
On Wed, 09 Sep 2015 22:24:11 +0200
address@hidden (Ludovic Courtès) wrote:
> Eric Bavier <address@hidden> skribis:
>
> > For Perl, my idea is to wrap each module somehow, so that perl gets the
> > appropriate 'use lib "/gnu/store/..."' when it loads each module.
> > Preferably the solution would also work with store deduplication.
> > I've not yet confirmed this is even feasible, so anyone with more perl
> > knowledge should chime in.
> >
> > Our haskell modules install files into a "package.conf.d" subdirectory,
> > and these files actually keep references to all haskell modules that
> > were configured in the environment when it was built. I'm baffled why
> > GHC does not make use of this information for dependency resolution when
> > it loads libraries. Perhaps we could hack our GHC to do so.
>
> This sounds like retrofitting some RUNPATH-like functionality in
> languages. This would be ideal, and we should use whatever already
> exists if that does the job (which seems to be the case for Perl?).
It exists for Perl to some degree, but 'use lib "/..."' rather than
simple 'use lib' needs to be explicitely used by the module author,
which is rarely done in practice.
>
> Otherwise we should really push upstream to implement that
> functionality.
>
> > From c7932475b95f22f891169b7f315366e2602fb4f5 Mon Sep 17 00:00:00 2001
> > From: Eric Bavier <address@hidden>
> > Date: Tue, 21 Jul 2015 20:45:54 -0500
> > Subject: [PATCH 5/6] guix: packages: Add transitive-input-references.
> >
> > * guix/packages.scm (transitive-input-references): New procedure.
> > * gnu/packages/version-control.scm (package-transitive-propagated-labels*)
> > (package-propagated-input-refs): Delete.
> > (git)[arguments]: Adjust to transitive-input-references.
>
> It addresses previous comments and looks reasonable to me.
>
> OK for ‘master’!
Pushed. Thanks!
`~Eric