Re: [PATCH 1/3] gnu: Add python-netaddr.

[Mathieu Lirzin]

This is Mostly about formatting issues here

Cyril Roelandt <address@hidden> writes:

> * gnu/packages/python.scm (python-netaddr, python2-netaddr): New variables.
> ---
>  gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index f9ad951..0231bce 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -4739,3 +4739,31 @@ reading and writing MessagePack data.")
>  
>  (define-public python2-msgpack
>    (package-with-python2 python-msgpack))
> +
> +(define-public python-netaddr
> +  (package
> +    (name "python-netaddr")
> +    (version "0.7.18")
> +    (source
> +      (origin

    (source
     (origin ...))
        
> +        (method url-fetch)
> +        (uri (string-append
> +               "https://pypi.python.org/packages/source/n/netaddr/netaddr-";
> +               version
> +               ".tar.gz"))
                 
    (string-append
     "..." 
     ...)

> +        (sha256
> +          (base32
> +            "06dxjlbcicq7q3vqy8agq11ra01kvvd47j4mk6dmghjsyzyckxd1"))))

    (base32
     "....")

> +    (build-system python-build-system)
> +    (arguments `(#:tests? #f)) ;; No tests.
                                  
                                           ;no tests

> +    (inputs
> +      `(("python-setuptools" ,python-setuptools)))
> +    (home-page "https://github.com/drkjam/netaddr/";)
> +    (synopsis
> +      "Pythonic manipulation of IPv4, IPv6, CIDR, EUI and MAC network 
> addresses")

In order to keep synopsis small and the description longer that
synopsis, maybe you an move "IPv4, IPv6, CIDR, EUI and MAC" into the
description?

> +    (description
> +      "A Python library for representing and manipulating network 
> addresses.")
> +    (license bsd-3)))
> +
> +(define-public python2-netaddr
> +  (package-with-python2 python-netaddr))

Otherwise LGTM.

--
Mathieu Lirzin