Re: [PATCH 04/19] gnu: Add r-bh.

[Vicente Vera]

Hello,

I don't know if the boost package in the distribution could be used to
comply with the requirements. IMO it is safer to incorporate r-bh as
it is needed by dplyr.

New patch with corrections attached.

2015-09-14 7:50 GMT-03:00 Ricardo Wurmus <address@hidden>:
>
>> * gnu/packages/statistics.scm (r-bh): New variable.
>
> [...]
>
>> +    (synopsis "Boost C++ Header Files")
>> +    (description
>> +     "Boost provides free peer-reviewed portable C++ source libraries.
>> +A large part of Boost is provided as C++ template code which is
>> +resolved entirely at compile-time without linking. This package aims
>> +to provide the most useful subset of Boost libraries for template use
>> +among CRAN package. By placing these libraries in this package, we
>> +offer a more efficient distribution system for CRAN as replication of
>> +this code in the sources of other packages is avoided.")
>> +    (license license:boost1.0)))
>
> It seems ugly to duplicate the Boost headers in a separate package.  We
> already have a “boost” package, which provides the headers for this
> version of Boost.  Would it be possible to use the existing “boost”
> package in place of “r-bh”?
>
> If not: please use two spaces in the description.  I think the first two
> sentences can be removed as they relate to the Boost library.  Also,
> please use lower case for the synopsis.
>
> ~~ Ricardo

0004-gnu-Add-r-bh.patch
Description: Text Data