[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add ruby-gherkin3
From: |
Thompson, David |
Subject: |
Re: [PATCH] gnu: Add ruby-gherkin3 |
Date: |
Tue, 15 Sep 2015 10:55:19 -0400 |
On Tue, Sep 15, 2015 at 10:48 AM, <address@hidden> wrote:
> * gnu/packages/ruby.scm (ruby-gherkin3): New variable.
Looks good to me. Just minor comments below.
> ---
> gnu/packages/ruby.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index ee0acc8..4756cd4 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -1124,3 +1124,28 @@ it unifies the API for web servers, web frameworks,
> and software in between
> into a single method call.")
> (home-page "http://rack.github.io/")
> (license license:expat)))
> +
> +(define-public ruby-gherkin3
> + (package
> + (name "ruby-gherkin3")
> + (version "3.1.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (rubygems-uri "gherkin3" version))
> + (sha256
> + (base32
> + "0xsyxhqa1gwcxzvsdy4didaiq5vam8ma3fbwbw2w60via4k6r1z9"))))
> + (build-system ruby-build-system)
> + (native-inputs
> + `(("bundler" ,bundler)
> + ("ruby-rspec" ,ruby-rspec)))
Let's remove rspec since we aren't running tests
> + (arguments
> + '(#:tests? #f)) ; needs simplecov, among others
> + (synopsis "Gherkin parser")
Maybe "Gherkin parser for Ruby"
> + (description "Gherkin 3 is a parser and compiler for the Gherkin
> +language. It is intended to replace Gherkin 2 and be used by all
> +Cucumber implementations to parse .feature files.")
> + (home-page
> + "https://github.com/cucumber/gherkin3")
Move to same line as 'home-page'.
> + (license expat)))
Needs prefix: license:expat
> --
> 2.4.3
>
>
- Dave